Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformer now requires PyTorch 1.6.0 #6277

Closed
sgugger opened this issue Aug 5, 2020 · 2 comments · Fixed by #6300
Closed

Reformer now requires PyTorch 1.6.0 #6277

sgugger opened this issue Aug 5, 2020 · 2 comments · Fixed by #6300

Comments

@sgugger
Copy link
Collaborator

sgugger commented Aug 5, 2020

@patrickvonplaten, one of your recent PR (#6244) on Reformer introduces a dep on PyTorch 1.6.0 minimum by using torch.cuda.default_generators. We should see if we can find a way to work around this.
@patrickvonplaten
Copy link
Contributor

yes! I think the change #6244 is also only necessary in PyTorch 1.6 -> maybe we can even hard-code torch.__version__ in the code and use the appropriate functions accordingly. Think this is also very much related to the previous bug: pytorch/pytorch#33546

@sgugger sgugger mentioned this issue Aug 6, 2020
Merged
@patrickvonplaten patrickvonplaten linked a pull request Aug 6, 2020 that will close this issue
[Reformer] fix default generators for pytorch < 1.6 #6300
Merged
@patrickvonplaten
Copy link
Contributor

#6300 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reformer] fix default generators for pytorch < 1.6 patrickvonplaten/transformers
2 participants
@patrickvonplaten @sgugger