Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reformer] Make random seed generator available on random seed and not on model device #6244

Merged

Conversation

patrickvonplaten
Copy link
Contributor

@LysandreJik - that might possibly fix the circle ci error.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #6244 into master will decrease coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6244      +/-   ##
==========================================
- Coverage   79.61%   79.30%   -0.32%     
==========================================
  Files         146      146              
  Lines       26597    26595       -2     
==========================================
- Hits        21175    21090      -85     
- Misses       5422     5505      +83     
Impacted Files Coverage Δ
src/transformers/configuration_encoder_decoder.py 100.00% <ø> (ø)
src/transformers/modeling_encoder_decoder.py 92.20% <ø> (ø)
src/transformers/benchmark/benchmark_args_utils.py 89.13% <100.00%> (ø)
src/transformers/modeling_reformer.py 95.68% <100.00%> (+0.19%) ⬆️
src/transformers/tokenization_utils_base.py 86.43% <100.00%> (-7.42%) ⬇️
src/transformers/modeling_tf_bert.py 70.11% <0.00%> (-26.82%) ⬇️
src/transformers/tokenization_roberta.py 76.71% <0.00%> (-21.92%) ⬇️
src/transformers/tokenization_transfo_xl.py 38.73% <0.00%> (-3.76%) ⬇️
src/transformers/tokenization_utils_fast.py 92.14% <0.00%> (-2.15%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b0a0e...1a7ae21. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the machine, it works flawlessly! Thanks!

@LysandreJik LysandreJik merged commit 6c9ba1d into huggingface:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants