Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bart: make decoder_input_ids correctly if labels specified. #6624

Closed
sshleifer opened this issue Aug 20, 2020 · 3 comments · Fixed by #6654 or #6758
Closed

Bart: make decoder_input_ids correctly if labels specified. #6624

sshleifer opened this issue Aug 20, 2020 · 3 comments · Fixed by #6654 or #6758
Assignees
@sshleifer
Labels
seq2seq
Projects
Examples/seq2seq

Comments

@sshleifer
Copy link
Contributor

should call shift_tokens_right(labels), like T5.

cc @patil-suraj: does that make sense?
@sshleifer sshleifer self-assigned this Aug 20, 2020
@sshleifer sshleifer added this to To do in Examples/seq2seq via automation Aug 20, 2020
@patil-suraj
Copy link
Contributor

Yes, definitely. Better to handle it in the model. Since lots of recent issues were due to incorrect or not shifting labels

@patil-suraj
Copy link
Contributor

But then prepare_seq2seq_batch should return labels instead of decoder_input_ids

@sshleifer
Copy link
Contributor Author

yep. I'll take a stab.

This was linked to pull requests Aug 27, 2020
prepare_seq2seq_batch makes labels/ decoder_input_ids made later. #6654
Merged
Bart can make decoder_input_ids from labels #6758
Merged
Examples/seq2seq automation moved this from To do to Done Aug 28, 2020
@freespirit freespirit mentioned this issue Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sshleifer sshleifer

Labels
seq2seq
Projects
Examples/seq2seq
  
Done
Milestone
No milestone
2 participants
@sshleifer @patil-suraj