Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bart can make decoder_input_ids from labels #6758

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Bart can make decoder_input_ids from labels #6758

merged 1 commit into from
Aug 31, 2020

Conversation

sshleifer
Copy link
Contributor

@sshleifer sshleifer commented Aug 26, 2020 •
edited
Loading

mimics a nice t5 feature

@codecov
Copy link

codecov bot commented Aug 26, 2020 •
edited
Loading

Codecov Report

Merging #6758 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6758      +/-   ##
==========================================
- Coverage   78.96%   78.96%   -0.01%     
==========================================
  Files         157      157              
  Lines       28486    28488       +2     
==========================================
+ Hits        22495    22496       +1     
- Misses       5991     5992       +1
Impacted Files Coverage Δ
src/transformers/modeling_bart.py 95.57% <100.00%> (+0.01%) ⬆️
src/transformers/file_utils.py 82.41% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75c64d...06e7cc5. Read the comment docs.

@sshleifer sshleifer linked an issue Aug 27, 2020 that may be closed by this pull request
Bart: make decoder_input_ids correctly if labels specified. #6624
Closed
@sshleifer sshleifer requested a review from sgugger August 27, 2020 22:25
sgugger
sgugger approved these changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sshleifer sshleifer merged commit 367235e into huggingface:master Aug 31, 2020
@sshleifer sshleifer deleted the bart-make-dec-ids branch August 31, 2020 20:16
stas00 pushed a commit to stas00/transformers that referenced this pull request Sep 1, 2020
@sshleifer @stas00
Bart can make decoder_input_ids from labels (huggingface#6758)
e79822c
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
@sshleifer @Zigur
Bart can make decoder_input_ids from labels (huggingface#6758)
7853124
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
@sshleifer @fabiocapsouza
Bart can make decoder_input_ids from labels (huggingface#6758)
f53d5ad
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
@fabiocapsouza
Revert "Bart can make decoder_input_ids from labels (huggingface#6758)"
2805245 
This reverts commit f53d5ad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@LysandreJik LysandreJik Awaiting requested review from LysandreJik

@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bart: make decoder_input_ids correctly if labels specified.
2 participants
@sshleifer @sgugger