New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing run_pl_glue.py from text classification docs, include run_xnli.py & run_tf_text_classification.py #10066
Removing run_pl_glue.py from text classification docs, include run_xnli.py & run_tf_text_classification.py #10066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! To make each version of the documentation point to the examples that go with it, the links should also be like this:
:prefix-link:`run_glue <examples/text-classification/run_glue.py>`__
This way the master will be replaced by the tag of the release when in the docs of a specific version.
Sure! Change applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
One last thing, could you run make style
on your branch so that the formatting is applied?
Done, command |
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Build still not succeeding. I will check |
Ah yes, those links don't need the underscores! Good catch and sorry for giving you the wrong example to follow. Just waiting for the last tests and we can merge :-) |
No worries, @sgugger. Thanks for the guidance :) |
What does this PR do?
Since
run_pl_glue.py
is not part oftext-classification
examples after #9010, this PR removes it from the text-classification docs. Also, it addsrun_xnli.py
andrun_tf_text_classification.py
scripts, which are in that folder now.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sgugger may be interested in the PR, he's responsible for docs and the author of #9010