Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added integration tests for Pytorch implementation of the ELECTRA model #10073

Merged
merged 5 commits into from Feb 8, 2021
Merged

Added integration tests for Pytorch implementation of the ELECTRA model #10073

merged 5 commits into from Feb 8, 2021

Conversation

spatil6
Copy link
Contributor

@spatil6 spatil6 commented Feb 8, 2021

Added integration tests for Pytorch implementation of the ELECTRA model

Fixes #9949

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@LysandreJik

@LysandreJik LysandreJik added this to In Progress in Integration tests for all models and tokenizers via automation Feb 8, 2021
LysandreJik
LysandreJik approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me!

@LysandreJik LysandreJik merged commit 263fac7 into huggingface:master Feb 8, 2021
Integration tests for all models and tokenizers automation moved this from In Progress to Done Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Integration tests for all models and ...
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Good first issue] ELECTRA PyTorch Integration tests
2 participants
@spatil6 @LysandreJik