Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Wav2Vec2ForMaskedLM and add Wav2Vec2ForCTC #10089

Merged
merged 2 commits into from Feb 9, 2021

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Feb 9, 2021

What does this PR do?

Deprecates Wav2Vec2ForMaskedLM -> the name was very badly chosen since it's currently used for CTC classification which is very different from MaskedLM. Also MaskedLM is not a good name for pretraining where it should rather be something like ForMaskedSpeechModeling, so IMO the best idea is to deprecate the whole class.

Right after this PR is merged and there is a patch, I will update all configs.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could we remove Wav2Vec2ForMaskedLM from the documentation?

@patrickvonplaten
Copy link
Contributor Author

patrickvonplaten commented Feb 9, 2021

LGTM! Could we remove Wav2Vec2ForMaskedLM from the documentation?

Yes! It's better than adding a note saying that the model is deprecated? => yeah let's just remove it!

@LysandreJik LysandreJik merged commit b972125 into huggingface:master Feb 9, 2021
@patrickvonplaten patrickvonplaten deleted the ctc_loss_wav2vec2 branch February 9, 2021 08:49
LysandreJik pushed a commit that referenced this pull request Feb 9, 2021
* add wav2vec2CTC and deprecate for maskedlm

* remove from docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants