Deprecate Wav2Vec2ForMaskedLM and add Wav2Vec2ForCTC #10089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecates
Wav2Vec2ForMaskedLM
-> the name was very badly chosen since it's currently used for CTC classification which is very different fromMaskedLM
. AlsoMaskedLM
is not a good name for pretraining where it should rather be something likeForMaskedSpeechModeling
, so IMO the best idea is to deprecate the whole class.Right after this PR is merged and there is a patch, I will update all configs.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.