Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some edge cases in report_to and add deprecation warnings #10100

Merged
merged 1 commit into from Feb 9, 2021
Merged

Fix some edge cases in report_to and add deprecation warnings #10100

merged 1 commit into from Feb 9, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Feb 9, 2021

What does this PR do?

This PR adds two new values for the report_to TrainingArguments:

  • "all" for all integrations installed
  • "none" for none (necessary when using in the CLI and we can't pass an empty list)

It also starts warning the user (with an info to not be too spammy) of the upcoming change of default in v5.

LysandreJik
LysandreJik approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM!

@sgugger sgugger merged commit 77c0ce8 into master Feb 9, 2021
@sgugger sgugger deleted the report_to_deprecate branch February 9, 2021 15:38
@sgugger sgugger mentioned this pull request Feb 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgugger @LysandreJik