Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing NER pipeline for list inputs. #10184

Merged
merged 1 commit into from Feb 15, 2021

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Feb 15, 2021

What does this PR do?

  • Changes TokenArgumentHandler(*args) into (inputs) signature to follow __call__ signature.
  • Fixes the bug.
  • Backward compatible for single sentences
  • Not backward compatible for multiple sentences, but it "worked" only for same length sentences in tokens (the result was bogus as it contained only the first sentence)
  • This make NER not pass any batching to the model, which is not in line with other pipelines, however this is what was done beforehand. And not all pipelines support batching (and even batching is counterproductive in a lot of cases because the user cannot control number of tokens from raw strings).
  • All slow tests now pass, argparser test was updated.

Fixes #10168

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@LysandreJik

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for taking care of it @Narsil!

@LysandreJik LysandreJik merged commit 900daec into huggingface:master Feb 15, 2021
@LysandreJik LysandreJik mentioned this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NER pipeline doesn't work for a list of sequences
2 participants