Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] fix func signature #10271

Merged
merged 1 commit into from Feb 19, 2021
Merged

[test] fix func signature #10271

merged 1 commit into from Feb 19, 2021

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Feb 18, 2021

This PR makes a small fix where the func argument cannot be None as it's used w/o checking it's None.

@sgugger

sgugger
sgugger approved these changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stas00 stas00 merged commit d9a81fc into huggingface:master Feb 19, 2021
@stas00 stas00 deleted the trainer-cleanup branch February 19, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stas00 @sgugger