Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to resize token embeddings matrix when adding new tokens to voc #10331

Merged
merged 1 commit into from Feb 22, 2021
Merged

Add note to resize token embeddings matrix when adding new tokens to voc #10331

merged 1 commit into from Feb 22, 2021
+6 −0

Conversation

LysandreJik
Copy link
Member

Closes #10319

sgugger
sgugger approved these changes Feb 22, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@LysandreJik LysandreJik merged commit e73a3e1 into master Feb 22, 2021
@LysandreJik LysandreJik deleted the resize_token_embeddings_note branch February 22, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] Add a new token to tokenizer and bart model
2 participants
@LysandreJik @sgugger