Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes overwrites for output_dir #10521

Merged
merged 3 commits into from Mar 4, 2021
Merged

Conversation

philschmid
Copy link
Member

What does this PR do?

This PR removes the overwrites of the output_dir when running training on SageMaker and it removes the automatic save if output_dir is None.
The overwrites have been removed since it prevents saving checkpoints to a different dir like opt/ml/checkpoints impossible and it is not the "transformers" way. We can keep it the same as running training somewhere else and provide documentation on what you need to do.

@philschmid philschmid requested a review from sgugger March 4, 2021 15:39
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!
Since this PR removes the auto-value for output_dir in the only situation it was optional, it should also remove the default in training_args (the argument is not optional anymore).

@philschmid philschmid merged commit 805c520 into master Mar 4, 2021
@philschmid philschmid deleted the remove-sm-overwrite-output-dir branch March 4, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants