[examples tests on multigpu] resolving require_torch_non_multi_gpu_but_fix_me #10561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas00
changed the title
Iwontbecreative
pushed a commit
to Iwontbecreative/transformers
that referenced
this pull request
Jul 15, 2021
…t_fix_me (huggingface#10561) * batch 1 * this is tpu * deebert attempt * the rest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago I added
@require_torch_non_multi_gpu_but_fix_meto quickly allow us to start running example tests on multigpu, so this PR resolves that temporary band-aid.This PR:
@require_torch_non_multi_gpu_but_fix_mefrom existence since it's no longer neededNote: 2 slow tests in
examples/test_examples.pycurrently fail because of yet another missed thing in portedrun_seq2seq.py- but these should be resolved by #10551 once that one is merged, so we can merge this PR after it.@LysandreJik