Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests of TrainerCallback #10615

Merged
merged 2 commits into from Mar 9, 2021
Merged

Fix tests of TrainerCallback #10615

merged 2 commits into from Mar 9, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Mar 9, 2021

What does this PR do?

When introducing the report_to argument, I must have messed something up. Bottomline is that the tests of TrainerCallback can fail depending on what is installed in the env (TensorBoard for instance), this PR fixes that.

@sgugger sgugger requested a review from LysandreJik March 9, 2021 21:24
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

tests/test_trainer_callback.py Outdated Show resolved Hide resolved
@LysandreJik LysandreJik merged commit 72d9e03 into master Mar 9, 2021
@LysandreJik LysandreJik deleted the fix_test_trainer_callback branch March 9, 2021 21:25
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
* Fix tests of TrainerCallback

* Update tests/test_trainer_callback.py

Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants