Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S2S + M2M100 should be available in tokenization_auto #10657

Merged
merged 3 commits into from Mar 11, 2021
Merged

S2S + M2M100 should be available in tokenization_auto #10657

merged 3 commits into from Mar 11, 2021

Conversation

LysandreJik
Copy link
Member

cc @patil-suraj

Was it a choice not to add these to the tokenizer auto, or is it because that's not covered in the template?

patil-suraj
patil-suraj approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

I missed it because it's not covered in the template.

@LysandreJik LysandreJik merged commit 6d9e11a into master Mar 11, 2021
@LysandreJik LysandreJik deleted the add-tokenizer-configs branch March 11, 2021 14:53
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
@LysandreJik @Iwontbecreative
S2S + M2M100 should be available in tokenization_auto (huggingface#10657
ed9525a 
)

* S2S + M2M100 should be available in tokenization_auto

* Requires sentencepiece

* SentencePiece for S2T as well :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patil-suraj patil-suraj patil-suraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LysandreJik @patil-suraj