TensorFlow tests: having from_pt set to True requires torch to be installed. #10664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LysandreJik - I'll upload the respective weights today and then check that all these slow tests here work without |
|
Uploaded all the TF weights and checked that:
pass. For some reason |
Iwontbecreative
pushed a commit
to Iwontbecreative/transformers
that referenced
this pull request
Jul 15, 2021
…talled. (huggingface#10664) * TF model exists for Blenderbot 400M * Marian * RAG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were executed without having torch installed, while they require torch. Namely, all the tests that have a
from_pt=Truerequirement require torch to be installed.This is a draft PR as several of the requirements to merge this PR are not met:
The easy option is to only set
@requires_torch, but since we have no slow test suite that runs both PT + TF that's not a good workaround.How do you want to proceed @patrickvonplaten ?