Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] RAG #10679

Merged
merged 1 commit into from Mar 15, 2021
Merged

[Tests] RAG #10679

merged 1 commit into from Mar 15, 2021
+0 −56

Conversation

patrickvonplaten
Copy link
Contributor

This PR shortens the RAG tests by simply reducing the batch size to 8. It's not ideal because RAG is a fairly complex model and IMO, it's good that we have such "big" integration tests. Maybe we should move those tests to a different @require_large_gpu decorator?

LysandreJik
LysandreJik approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Right, we could setup a machine with large GPUs; maybe not now as the need is low but as large models get added it will start to make more sense. Maybe we can just add a comment here so that we know where to look once we have that CI in place?

sgugger
sgugger approved these changes Mar 12, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@patrickvonplaten patrickvonplaten merged commit bd8f6ca into huggingface:master Mar 15, 2021
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
@patrickvonplaten @Iwontbecreative
make rag tests smaller (huggingface#10679)
c0759a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrickvonplaten @LysandreJik @sgugger