Add transformers id to hub requests #10811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1t0
approved these changes
Mar 19, 2021
src/transformers/file_utils.py
Outdated
| @@ -213,6 +214,7 @@ | |||
| PYTORCH_PRETRAINED_BERT_CACHE = os.getenv("PYTORCH_PRETRAINED_BERT_CACHE", default_cache_path) | |||
| PYTORCH_TRANSFORMERS_CACHE = os.getenv("PYTORCH_TRANSFORMERS_CACHE", PYTORCH_PRETRAINED_BERT_CACHE) | |||
| TRANSFORMERS_CACHE = os.getenv("TRANSFORMERS_CACHE", PYTORCH_TRANSFORMERS_CACHE) | |||
| TRANSFORMERS_ID = uuid4().hex | |||
There was a problem hiding this comment.
I had a preference for the previous name SESSION_ID that I find more informative.
julien-c
reviewed
Mar 19, 2021
| @@ -1211,7 +1213,7 @@ def http_user_agent(user_agent: Union[Dict, str, None] = None) -> str: | |||
| """ | |||
| Formats a user-agent string with basic info about a request. | |||
| """ | |||
| ua = "transformers/{}; python/{}".format(__version__, sys.version.split()[0]) | |||
| ua = f"transformers/{__version__}; python/{sys.version.split()[0]}; session_id/{SESSION_ID}" | |||
There was a problem hiding this comment.
should we trim the id slightly to e.g. 12 chars? @philschmid cc @n1t0
There was a problem hiding this comment.
I don't have a strong opinion on this
There was a problem hiding this comment.
I wanted to leave this unchanged and adding 20 more characters to it won`t be that big of a problem. But I am open to adjusting it.
Iwontbecreative
pushed a commit
to Iwontbecreative/transformers
that referenced
this pull request
Jul 15, 2021
* add uuid.hext to user_agent * add log * changed order of it * renamed as session id * renamed variable * reverted naming of the const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a
TRANSFORMERS_IDconst, which helps us to group the several files request against the hub.