Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trainer] Fixes Typo in Predict Method of Trainer #10861

Merged
merged 1 commit into from Mar 23, 2021
Merged

[trainer] Fixes Typo in Predict Method of Trainer #10861

merged 1 commit into from Mar 23, 2021

Conversation

bhadreshpsavani
Copy link
Contributor

What does this PR do?

Fixes typo in Predict Method of Trainer. This will enable saving files with the correct prefix test in Predict stage. Earlier it was saving it with the eval prefix for both predict and evaluate stage.

Before submitting

Who can review?:

@stas00 @sgugger

Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing this issue and providing a fix, @bhadreshpsavani

@stas00 stas00 requested a review from sgugger March 23, 2021 04:59
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@sgugger sgugger merged commit eb330e8 into huggingface:master Mar 23, 2021
@bhadreshpsavani bhadreshpsavani deleted the trainer-predict-fix branch March 23, 2021 13:56
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants