Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix head_mask for albert encoder part(AlbertTransformer) #11596

Merged
merged 2 commits into from May 6, 2021
Merged

fix head_mask for albert encoder part(AlbertTransformer) #11596

merged 2 commits into from May 6, 2021

Conversation

baeseongsu
Copy link
Contributor

What does this PR do?

Fixes #8323

Fix a subtle bug for using a submodule AlbertTransformer in AlbertModel.

Who can review?

@LysandreJik

@LysandreJik
Copy link
Member

Great, thanks for the fix @baeseongsu ! Could you run the code quality tool to ensure the PR fits the quality requirements?

pip install -U -e .[quality]
make fixup

@baeseongsu
Copy link
Contributor Author

@LysandreJik Sure 👍

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @baeseongsu!

@LysandreJik LysandreJik merged commit c1780ce into huggingface:master May 6, 2021
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
…ce#11596)

* fix head mask for albert encoder part

* fix head_mask for albert encoder part
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlbertTransformer head_mask not subscriptable error when not passed
2 participants