[Lazy init] Fix edge cases #11615
Merged
[Lazy init] Fix edge cases #11615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
commented
May 6, 2021
| retrieved_modules = [] | ||
| # retrieve all modules that has at least one missing weight name | ||
| for name, module in self.named_modules(): | ||
| if remove_prefix: | ||
| name = ".".join(name.split(".")[1:]) if name.startswith(self.base_model_prefix) else name | ||
| elif add_prefix: | ||
| name = ".".join([self.base_model_prefix, name]) | ||
| name = ".".join([self.base_model_prefix, name]) if len(name) > 0 else self.base_model_prefix |
There was a problem hiding this comment.
weird edge case in which the module is just an empty string '' which will then lead to bert. instead of the correct bert key
patrickvonplaten
commented
May 6, 2021
| @@ -1347,13 +1350,17 @@ def load(module: nn.Module, prefix=""): | |||
| def retrieve_modules_from_names(self, names, add_prefix=False, remove_prefix=False): | |||
| module_keys = set([".".join(key.split(".")[:-1]) for key in names]) | |||
|
|
|||
| # torch.nn.ParameterList is a special case where two parameter keywords | |||
| # are appended to the module name, *e.g.* bert.special_embeddings.0 | |||
| module_keys = module_keys.union(set([".".join(key.split(".")[:-2]) for key in names if key[-1].isdigit()])) | |||
There was a problem hiding this comment.
torch.nn.ParameterList is special in a sense that it adds to word with '.' to a module so that we need to remove the last to "."'s
Iwontbecreative
pushed a commit
to Iwontbecreative/transformers
that referenced
this pull request
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the flaky circle ci regarding tests such as
tests/test_modeling_xlnet.py::XLNetModelTest::test_save_load_fast_init_to_base.Luckily, the test caught those edge cases ;-)