New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] fix sys.path in conftest.py #11636
Conversation
That can't work since Path in conftest need to be adapted instead. |
ah, OK, then I will make copies of it. But you can't move it since sys.path was relying on it being in a top-level subfolder - so will have to fix that or make the code more flexible. It's currently broken. I will take care of it. thank you for letting me know tf didn't like it. |
ok,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix in itself LGTM but why add a conftest to legacy and research-projects? Both are not supposed to be tested.
I'm adding deepspeed tests for wav2vec2 - it's been complicated to make it work (some parts still don't work). So I want to make sure it doesn't break again. I don't think it's a good idea to put these tests under common tests. So I can't run the tests w/o this conftest on dev box. |
I really don't think it's a good idea to add this to Maybe add it specifically to the wav2vec2 research project? Or maybe wav2vec2 should move to a maintained example @patrickvonplaten ? |
Good point! OK, will recall the 2 other files for now.
Yes, totally agree! |
|
* restore conftest.py * fix conftest and make copies * remove unneeded parts * remove unwanted files
the pt/tf reshuffle broke the examples tests setup. This PR fixes it, by
sys.path
setting now that it's one level down@sgugger