New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flax] Updates README and fixes bug #11701
Conversation
@@ -473,8 +473,8 @@ def eval_step(state, batch): | |||
dropout_rngs = shard_prng_key(dropout_rng) | |||
state, metrics = p_train_step(state, batch, dropout_rngs) | |||
train_metrics.append(metrics) | |||
train_time += time.time() - train_start | |||
logger.info(f" Done! Training metrics: {unreplicate(metrics)}") | |||
train_time += time.time() - train_start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for listing the prices!
Just one nit from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
What does this PR do?
Adds information about costs/pricing for Flax Bert Text Classification example.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.