Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unwanted control-flow code from DeBERTa-V2 #13145

Merged
merged 1 commit into from
Aug 23, 2021
Merged

remove unwanted control-flow code from DeBERTa-V2 #13145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/transformers/models/deberta_v2/modeling_deberta_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,8 +753,6 @@ def disentangled_attention_bias(self, query_layer, key_layer, relative_pos, rel_
r_pos = relative_pos

p2c_pos = torch.clamp(-r_pos + att_span, 0, att_span * 2 - 1)
if query_layer.size(-2) != key_layer.size(-2):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All

  ``` self.query_proj = nn.Linear(config.hidden_size, self.all_head_size, bias=True)
    self.key_proj = nn.Linear(config.hidden_size, self.all_head_size, bias=True)
    self.value_proj = nn.Linear(config.hidden_size, self.all_head_size, bias=True)```

have the same dim which is why this control flow is never true no?

LGTM to remove for me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have the same dim which is why this control flow is never true no?

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deberta-v2 same dim always. so the control flow is never true

pos_index = relative_pos[:, :, :, 0].unsqueeze(-1)

if "p2c" in self.pos_att_type:
p2c_att = torch.bmm(key_layer, pos_query_layer.transpose(-1, -2))
Expand All @@ -763,25 +761,13 @@ def disentangled_attention_bias(self, query_layer, key_layer, relative_pos, rel_
dim=-1,
index=p2c_pos.squeeze(0).expand([query_layer.size(0), key_layer.size(-2), key_layer.size(-2)]),
).transpose(-1, -2)
if query_layer.size(-2) != key_layer.size(-2):
p2c_att = torch.gather(
p2c_att,
dim=-2,
index=pos_index.expand(p2c_att.size()[:2] + (pos_index.size(-2), key_layer.size(-2))),
)
score += p2c_att / scale

# position->position
if "p2p" in self.pos_att_type:
pos_query = pos_query_layer[:, :, att_span:, :]
p2p_att = torch.matmul(pos_query, pos_key_layer.transpose(-1, -2))
p2p_att = p2p_att.expand(query_layer.size()[:2] + p2p_att.size()[2:])
if query_layer.size(-2) != key_layer.size(-2):
p2p_att = torch.gather(
p2p_att,
dim=-2,
index=pos_index.expand(query_layer.size()[:2] + (pos_index.size(-2), p2p_att.size(-1))),
)
p2p_att = torch.gather(
p2p_att,
dim=-1,
Expand Down