Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the documentation #13361

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Fixes for the documentation #13361

merged 1 commit into from
Sep 1, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Aug 31, 2021

What does this PR do?

This PR contains a few fixes necessary for me to build the documentation with custom tooling. They are all making the current documentation better as well, so this shouldn't cause any problems to merge.

Comment on lines +19 to +28
from .data_collator import (
DataCollatorForLanguageModeling,
DataCollatorForPermutationLanguageModeling,
DataCollatorForSeq2Seq,
DataCollatorForSOP,
DataCollatorForTokenClassification,
DataCollatorForWholeWordMask,
DataCollatorWithPadding,
default_data_collator,
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not directly relevant to the current documentation but is necessary for "data_collator" to be recognized properly as a submodule of transformers.data
I don't think it's a problem to have it here.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sgugger

@sgugger sgugger merged commit 7a26307 into master Sep 1, 2021
@sgugger sgugger deleted the doc_fixes branch September 1, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants