Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flax] Fix BigBird #13380

Merged

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Sep 1, 2021

What does this PR do?

PyTorch BigBird was changed in a recent PR: ba1b3db but the Flax version wasn't changed accordingly.

Thanks for spotting it @sgugger

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten patrickvonplaten changed the title Fix big bird flax [Flax] Fix BigBird Sep 1, 2021
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! On the equivalence tests, would it make sense to have one in the Flax common tests and one in the PyTorch common tests? This would have caught the problem on the original PR.

@patrickvonplaten
Copy link
Contributor Author

I see -> yeah we can do this!

@patrickvonplaten patrickvonplaten merged commit 4475f1d into huggingface:master Sep 1, 2021
@patrickvonplaten patrickvonplaten deleted the fix_big_bird_flax branch September 1, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants