Tapas tf #13393
Tapas tf #13393
Conversation
|
|
|
pending
|
kamalkraj
force-pushed
the
tapas-tf
branch
2 times, most recently
from
13269bf
to
477463f
Compare
|
@LysandreJik |
|
Great news @kamalkraj! @NielsRogge and @Rocketknight1, could you take a look at this? |
kamalkraj
force-pushed
the
tapas-tf
branch
2 times, most recently
from
47f0d80
to
aacddb8
Compare
|
Hi, I'd like to apologize for not getting to this sooner! It's a huge PR, but I'll try to get through it today or tomorrow and give feedback where I can. |
|
Thanks, @Rocketknight1 @NielsRogge |
|
@kamalkraj sure! Btw I just discovered a (tiny) bug in the forward pass of TAPAS (when |
|
@kamalkraj I'm uploading all TAPAS TF checkpoints to the hub. Can you resolve the conflict shown above? Also, can you confirm the |
|
@NielsRogge |
|
The TF version should not be pinned, but the TF probability version can be pinned. |
|
@NielsRogge But in the CI Tensorflow installed is 2.6.2, Any idea Current TF latest version is 2.7 |
|
It seems that this is due to pip not upgrading itself correctly: Could you try to update the following in your PR: transformers/.circleci/config.yml Line 82 in 25156eb to to check if it changes anything? Thanks, @kamalkraj |
|
Thanks for trying it out, it seems like it didn't work out. I'll try a few things and come back to you. |
|
Found the error! TensorFlow 2.7 does not support Python 3.6 anymore (cc @sgugger, @Rocketknight1, @patrickvonplaten, @patil-suraj). Could you update this line: https://github.com/huggingface/transformers/blob/master/.circleci/config.yml#L68 to have |
|
Thanks @LysandreJik Should I revert this commit f18cfa9? I have changed the python version only here |
|
@NielsRogge Ready to merge 🤗 |
|
Indeed, if you can revert the pip commit then we're ready to go! We can also merge it and revert it afterwards, do you want to take care of that @NielsRogge? |
|
Fantastic @kamalkraj, let's merge it once it's all green |
* TF Tapas first commit * updated docs * updated logger message * updated pytorch weight conversion script to support scalar array * added use_cache to tapas model config to work properly with tf input_processing * 1. rm embeddings_sum 2. added # Copied 3. + TFTapasMLMHead 4. and lot other small fixes * updated docs * + test for tapas * updated testing_utils to check is_tensorflow_probability_available * converted model logits post processing using numpy to work with both PT and TF models * + TFAutoModelForTableQuestionAnswering * added TF support * added test for TFAutoModelForTableQuestionAnswering * added test for TFAutoModelForTableQuestionAnswering pipeline * updated auto model docs * fixed typo in import * added tensorflow_probability to run tests * updated MLM head * updated tapas.rst with TF model docs * fixed optimizer import in docs * updated convert to np data from pt model is not `transformers.tokenization_utils_base.BatchEncoding` after pipeline upgrade * updated pipeline: 1. with torch.no_gard removed, pipeline forward handles 2. token_type_ids converted to numpy * updated docs. * removed `use_cache` from config * removed floats_tensor * updated code comment * updated Copyright Year and logits_aggregation Optional * updated docs and comments * updated docstring * fixed model weight loading * make fixup * fix indentation * added tf slow pipeline test * pip upgrade * upgrade python to 3.7 * removed from_pt from tests * revert commit f18cfa9
What does this PR do?
TF Tapas
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@NielsRogge @sgugger @LysandreJik @Rocketknight1