Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update dead quickstart link on resuing past for GPT2 #13455

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

shabie
Copy link
Contributor

@shabie shabie commented Sep 6, 2021

Thed dead link have been replaced by two links of forward and call methods of the GPT2 class for torch and tensorflow respectively.

What does this PR do?

This PR replaces the dead link with two new links on showing how to reuse the precomputed attention values.

Fixes #13434

Before submitting

  • [ X] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Thed dead link have been replaced by two links of forward and call methods of the GPT2 class for torch and tensorflow respectively.
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing!

Could you just run make style on your branch to fix the code quality issue?

@shabie
Copy link
Contributor Author

shabie commented Sep 7, 2021

Thanks a lot for fixing!

Could you just run make style on your branch to fix the code quality issue?

Done.

@sgugger sgugger merged commit 4be082c into huggingface:master Sep 7, 2021
@sgugger
Copy link
Collaborator

sgugger commented Sep 7, 2021

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A dead link in GPT2 description
2 participants