Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix img classification tests #13456

Merged

Conversation

nateraw
Copy link
Contributor

@nateraw nateraw commented Sep 7, 2021

What does this PR do?

Fixes unittest issues from #13134. First there was an issue of missing torchvision, which was resolved with #13438 , but when that didn't fix it we skipped test_run_image_classification with #13451

Additionally, I added a test dataset to our internal testing org on huggingface.co, which is what we're using in the test now. Its 50 examples from the cats_vs_dogs dataset instead of the 10 that were in the text fixtures before.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM! Thank you for adding everything to a dataset.

@LysandreJik LysandreJik merged commit 7981509 into huggingface:master Sep 7, 2021
@nateraw nateraw deleted the fix-img-classification-tests branch September 7, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants