-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable automated model list copying for localized READMEs #13465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your PR, it looks very cool! I have left a few comments and let's also see if @JetRunner has some comments.
@qqaatw Thanks for taking care of this - I'm thinking since currently, the traditional Chinese version of |
@JetRunner Thanks for your reply! I think this depends on the preference of simplified Chinese users. Translated or not has no difference since this PR introduces a way that directly captures metadata from the English version, and the captured metadata can be substituted into any predefined localized model description format string. Considering If there are more localized READMEs translated in the future, let's say Japanese version of README, this method can also apply to the model list of these READMEs. In addition, some of models have supplemental data that can be manually translated after automated copying. For example, the text below is the supplemental data of
The simplified Chinese version has the supplemental data translated, which looks good to me:
|
Sounds great ;) |
One exception I found is that there are few models (GPT-J, GPT-Neo, and T5v1.1) using |
@sgugger The suggestions you provided have been applied. Thanks for the review! |
Just committed one last ypo fix, thanks a lot for your PR! |
What does this PR do?
Currently, the model list in each localized README such as
README_zh-hans.md
is updated manually, this PR introduces automated model list copying for localized READMEs. A proper tester for this change has been included in this PR.The model list of a localized README is updated through the following steps:
BERT
.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sgugger