Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use powers of 2 in download size calculations #13468

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Use powers of 2 in download size calculations #13468

merged 1 commit into from
Sep 7, 2021

Conversation

anton-l
Copy link
Member

@anton-l anton-l commented Sep 7, 2021

This fix makes 1GB = 1024MB instead of the default 1000MB in the from_pretrained() progress bars, which makes the download sizes consistent with the HF Hub file sizes.

Thanks to @stas00 for catching this!

@anton-l anton-l requested a review from sgugger September 7, 2021 20:29
@stas00 stas00 merged commit 2146833 into huggingface:master Sep 7, 2021
@stas00
Copy link
Contributor

stas00 commented Sep 7, 2021

Thank you, @anton-l!

@anton-l anton-l deleted the fix-download-size branch September 8, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stas00 stas00 stas00 approved these changes

@sgugger sgugger Awaiting requested review from sgugger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anton-l @stas00