Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in "end_of_word_suffix" #13477

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Typo in "end_of_word_suffix" #13477

merged 1 commit into from
Sep 8, 2021

Conversation

KoichiYasuoka
Copy link
Contributor

But does it really work?

@KoichiYasuoka
Typo in "end_of_word_suffix"
29c774c 
But does it really work?
sgugger
sgugger approved these changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it not work? always set by the tokenizer_json and never overridden by the kwargs.

SaulLu
SaulLu approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@SaulLu SaulLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having spotted this typo!

@sgugger sgugger merged commit 330d83f into huggingface:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@SaulLu SaulLu SaulLu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KoichiYasuoka @sgugger @SaulLu