Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests for TFWav2Vec2 and TFHubert #13480

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fix integration tests for TFWav2Vec2 and TFHubert #13480

merged 1 commit into from
Sep 8, 2021

Conversation

anton-l
Copy link
Member

@anton-l anton-l commented Sep 8, 2021

Issue
Errors for integration tests on TFWav2Vec2 and TFHubert

E           ValueError: When setting ``truncation=True``, make sure that ``max_length`` is defined and ``padding='max_length'

CI logs: https://github.com/huggingface/transformers/runs/3539314355?check_suite_focus=true

Solution
Remove truncation=True from feature extractors since the logic changed recently #12804
Also some other small fixes because the tests now reach those lines 馃檪

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @anton-l!

@anton-l anton-l merged commit e1f6e49 into huggingface:master Sep 8, 2021
@anton-l anton-l deleted the fix-tf-speech-integration branch September 8, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants