Warn for unexpected argument combinations #13509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirayu
changed the title
shirayu
changed the title
|
@sgugger |
sgugger
approved these changes
Sep 23, 2021
LysandreJik
reviewed
Sep 24, 2021
stas00
pushed a commit
to stas00/transformers
that referenced
this pull request
Oct 12, 2021
* Warn for unexpected argument combinations * Updated the waning message for pad_to_max_length
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 13, 2022
* Warn for unexpected argument combinations * Updated the waning message for pad_to_max_length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Warn for unexpected argument combinations:
padding is Trueandmax_length is not Nonepadding is Trueandpad_to_max_length is not FalseBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.