Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tokenizer] use use_auth_token for config #13523

Merged
merged 2 commits into from
Sep 13, 2021
Merged

[tokenizer] use use_auth_token for config #13523

merged 2 commits into from
Sep 13, 2021

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Sep 11, 2021

This PR forwards use_auth_token to AutoConfig.from_pretrained() when AutoTokenizer.from_pretrained(mname, use_auth_token=True) is used. Otherwise AutoConfig fails to retrieve config.json with 404.

Model's from_pretrained does the right thing.

@sgugger, @LysandreJik

sgugger
sgugger approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

LysandreJik
LysandreJik approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @stas00!

@LysandreJik LysandreJik merged commit f1c22da into huggingface:master Sep 13, 2021
@stas00 stas00 deleted the tokenizer-config-auth branch September 13, 2021 17:02
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
@stas00
[tokenizer] use use_auth_token for config (huggingface#13523)
c1a0e98 
* [tokenizer] use use_auth_token for config

* args order
@YouJiacheng YouJiacheng mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stas00 @LysandreJik @sgugger