[Speech2Text] Give feature extraction higher tolerance #13538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-l
reviewed
Sep 13, 2021
There was a problem hiding this comment.
@patrickvonplaten I ran the test in a loop and encountered variances up to 6.48907812e+05, which is highly unusual. Will look into it further in #13539
|
Merging this for now to keep the CI green - ran the test in loop 50 times locally without failure. |
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes flaky test: tests/test_feature_extraction_speech_to_text.py::Speech2TextFeatureExtractionTest::test_cepstral_mean_and_variance_normalization_np
@patil-suraj @anton-l - I looked quite a bit into it and IMO it's not a bug in the computation, but due to differences in casting "pure python" to "numpy".
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.