Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Extractors] Return attention mask always in int32 #13543

Merged

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Sep 13, 2021

What does this PR do?

This PR fixes:

tests/test_modeling_tf_hubert.py::TFHubertModelIntegrationTest::test_inference_ctc_robust_batched
tests/test_modeling_tf_wav2vec2.py::TFWav2Vec2ModelIntegrationTest::test_inference_ctc_robust_batched

For some specific use cases the attention mask for feature extractors was returned to be of type bool which broke two tf slow tests. Make sure that it's always int32 or long just like the tokenizers do for text.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wdyt @Rocketknight1 ?

Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! Since the tensor casting logic is not changed on the TF side of the library, this shouldn't cause any problems down the road.

@Rocketknight1
Copy link
Member

LGTM! I think lots of stuff breaks with boolean attention masks, so we definitely want to avoid sending that to the model.

@patrickvonplaten patrickvonplaten merged commit 5c14fce into huggingface:master Sep 13, 2021
@patrickvonplaten patrickvonplaten deleted the attn_mask_in_int32 branch September 13, 2021 12:03
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants