Fix test_fetcher when setup is updated #13566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
commented
Sep 14, 2021
setup.py
Outdated
| @@ -134,7 +134,7 @@ | |||
| "sacremoses", | |||
| "sagemaker>=2.31.0", | |||
| "scikit-learn", | |||
| "sentencepiece==0.1.91", | |||
| "sentencepiece==0.1.96", | |||
There was a problem hiding this comment.
This is just for demonstration, will remove before merging.
LysandreJik
approved these changes
Sep 14, 2021
5 tasks
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 13, 2022
* Fix test_fetcher when setup is updated * Remove example
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
* Fix test_fetcher when setup is updated * Remove example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When we update a dependency, it's better to run all tests to make sure we catch any failure linked to that new dep. This PR adapts the
test_fectcherto make sure this is the case.