Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] nightly: add deepspeed master #13589

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[ci] nightly: add deepspeed master #13589

merged 1 commit into from
Sep 16, 2021

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Sep 16, 2021

We recently saw bugs introduced in Deepspeed master that were caught only on their new release. Which creates a gap in time where deepspeed integration doesn't work. To avoid that let's also test deepspeed master with the pytorch-nightly as there both pushing the bleeding edge.

Additionally this PR fixes the nightly pip install line that was misplaced originally. and pushes it first, before any other installs. Otherwise we end up first installing the current pytorch via dependencies of sub-packages, and then again the nightly.

@LysandreJik

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stas00

@LysandreJik LysandreJik merged commit 89da1bf into master Sep 16, 2021
@LysandreJik LysandreJik deleted the stas00-patch-4 branch September 16, 2021 00:18
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants