Feature Extractor: Wav2Vec2 & Speech2Text - Allow truncation + padding=longest #13600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
changed the title
| raise ValueError( | ||
| "When setting ``truncation=True``, make sure that ``max_length`` is defined and ``padding='max_length'``" | ||
| ) | ||
| raise ValueError("When setting ``truncation=True``, make sure that ``max_length`` is defined.") |
There was a problem hiding this comment.
Now we do allow truncation=True + padding="longest"
patrickvonplaten
requested review from
anton-l,
LysandreJik,
sgugger and
patil-suraj
sgugger
approved these changes
Sep 16, 2021
anton-l
approved these changes
Sep 16, 2021
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
patrickvonplaten
deleted the
correct_sequence_feat_extractor_truncation
branch
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 13, 2022
…g=longest (huggingface#13600) * correct * add tests * Update src/transformers/feature_extraction_sequence_utils.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
…g=longest (huggingface#13600) * correct * add tests * Update src/transformers/feature_extraction_sequence_utils.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For training is speech it's quite important that we are able to make use of the
padding="longest"a.k.a dynamic batching in PyTorch on GPU since speech inputs can vary from 2 seconds to up to 30 seconds. We also want to be able to use truncation withpadding="longest"in such a case. This PR enables using truncation (i.e. cutting sequences to a max length of x seconds) with thepadding="longest"mode.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.