Fix FNet reference to tpu short seq length #13686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
approved these changes
Sep 22, 2021
Narsil
pushed a commit
to Narsil/transformers
that referenced
this pull request
Sep 25, 2021
|
@gchhablani are you btw. working on a flax integration of FNet 🤔 -> I've seen an attempt in this PR #12454 but it was closed. Would be really interesting to train FNet on TPU - GPU is working for me, but I only have one available... |
stas00
pushed a commit
to stas00/transformers
that referenced
this pull request
Oct 12, 2021
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 13, 2022
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes #13684.
Should there also be a test for this particular case (TPU usage, less than 4096 seq length) ?
@LysandreJik @patrickvonplaten