Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace torch.set_grad_enabled by torch.no_grad #13703

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Replace torch.set_grad_enabled by torch.no_grad #13703

merged 1 commit into from
Sep 23, 2021

Conversation

LysandreJik
Copy link
Member

Replace torch.set_grad_enabled by torch.no_grad in the ONNX converter

sgugger
sgugger approved these changes Sep 22, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@LysandreJik LysandreJik merged commit 41c186d into master Sep 23, 2021
@LysandreJik LysandreJik deleted the torch-no-grad-in-onnx branch September 23, 2021 21:08
Narsil pushed a commit to Narsil/transformers that referenced this pull request Sep 25, 2021
@LysandreJik @Narsil
Replace torch.set_grad_enabled by torch.no_grad (huggingface#13703)
11764a4
stas00 pushed a commit to stas00/transformers that referenced this pull request Oct 12, 2021
@LysandreJik @stas00
Replace torch.set_grad_enabled by torch.no_grad (huggingface#13703)
ae228b5
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
@LysandreJik
Replace torch.set_grad_enabled by torch.no_grad (huggingface#13703)
900da21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LysandreJik @sgugger