Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle UnicodeDecodeError when loading config file #13717

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

qqaatw
Copy link
Contributor

@qqaatw qqaatw commented Sep 23, 2021

What does this PR do?

This PR handles the UnicodeDecodeError mentioned in #13674, providing a better error message.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@LysandreJik @sgugger

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @qqaatw!

@LysandreJik LysandreJik merged commit 1988849 into huggingface:master Sep 23, 2021
@qqaatw qqaatw deleted the better_error_handling branch September 24, 2021 00:09
Narsil pushed a commit to Narsil/transformers that referenced this pull request Sep 25, 2021
stas00 pushed a commit to stas00/transformers that referenced this pull request Oct 12, 2021
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants