Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loss computation in Trainer #13760

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Fix loss computation in Trainer #13760

merged 1 commit into from
Sep 27, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Sep 27, 2021

What does this PR do?

This PR fixes the loss computation in Trainer, as indicated in #13758

Co-authored-by: quantitative-technologies <james.hirschorn@quantitative-technologies.com>
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! Will include it in the release.

@LysandreJik LysandreJik merged commit 3ffd18a into master Sep 27, 2021
@LysandreJik LysandreJik deleted the fix_loss_trainer branch September 27, 2021 11:33
stas00 pushed a commit to stas00/transformers that referenced this pull request Oct 12, 2021
Co-authored-by: quantitative-technologies <james.hirschorn@quantitative-technologies.com>

Co-authored-by: quantitative-technologies <james.hirschorn@quantitative-technologies.com>
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
Co-authored-by: quantitative-technologies <james.hirschorn@quantitative-technologies.com>

Co-authored-by: quantitative-technologies <james.hirschorn@quantitative-technologies.com>
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
Co-authored-by: quantitative-technologies <james.hirschorn@quantitative-technologies.com>

Co-authored-by: quantitative-technologies <james.hirschorn@quantitative-technologies.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants