minimal fixes to run DataCollatorForWholeWordMask with return_tensors="np" and return_tensors="tf" #13891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses #13890 with the minimal fixes to run
DataCollatorForWholeWordMask
withreturn_tensors="np"
andreturn_tensors="tf"
Specific problems addressed:
np_call
->numpy_call
_numpy_collate_batch
instead of_tf_collate_batch
when returning numpy tensorsrandom_words
innumpy_mask_tokens
tf.identity(tensor)
tf.convert_to_tensor
withdtype=tf.bool
totf.cast
withdtype=tf.bool
I've only added a simple test to check for regressions vs all of the padded/unpadded cases as is done for
DataCollatorForLanguageModeling
Fixes #13890
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
CC @Rocketknight1 (looks like you did the initial Numpy/TF implementation of these data collators)