Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace asserts by value error #13894

Merged
merged 1 commit into from Oct 5, 2021
Merged

fix: replace asserts by value error #13894

merged 1 commit into from Oct 5, 2021

Conversation

m5l14i11
Copy link
Contributor

@m5l14i11 m5l14i11 commented Oct 5, 2021

What does this PR do?

The PR addresses issue #12789.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@m5l14i11 m5l14i11 mentioned this pull request Oct 5, 2021
Closed
sgugger
sgugger approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sgugger sgugger merged commit 7af7d7c into huggingface:master Oct 5, 2021
stas00 pushed a commit to stas00/transformers that referenced this pull request Oct 12, 2021
@m5l14i11 @stas00
fix: replace asserts by error (huggingface#13894)
4192476
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
@m5l14i11
fix: replace asserts by error (huggingface#13894)
ba89c6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m5l14i11 @sgugger