[wav2vec2] fix --gradient_checkpointing #13964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
reviewed
Oct 11, 2021
There was a problem hiding this comment.
The research projects are not actively maintained and pinned under a Transformers version, which is why I did not update them, cc @patrickvonplaten
|
it was failing deepspeed tests for wav2vec2 - which I still run manually to check that Deepspeed didn't break something. wav2vec2 is a complex model with several manual fixes to make DS work. but I hear you about the pinned version! This makes sense. I was running those with master, so should probably add a skip rule to match the pinned version. Which would make it much more difficult for me to run the tests. |
5 tasks
|
@patrickvonplaten, do we merge this or close the PR? Thank you! |
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
--gradient_checkpointingin wav2vec2 examples.@sgugger