[Speech] Refactor Examples #14040
Merged
[Speech] Refactor Examples #14040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait until #14026 (comment) is fixed |
| @@ -476,6 +476,8 @@ | |||
| # Model for Audio Classification mapping | |||
| ("wav2vec2", "Wav2Vec2ForSequenceClassification"), | |||
| ("hubert", "HubertForSequenceClassification"), | |||
| ("sew", "SEWForSequenceClassification"), | |||
There was a problem hiding this comment.
Similar to how all BERT heads (ForQA, ForSequenceClass, ForMC, ...) are added to all BERT-like models for easy comparison and added functionality, all speech models should have the superb heads.
LysandreJik
approved these changes
Oct 18, 2021
| @@ -476,6 +476,8 @@ | |||
| # Model for Audio Classification mapping | |||
| ("wav2vec2", "Wav2Vec2ForSequenceClassification"), | |||
| ("hubert", "HubertForSequenceClassification"), | |||
| ("sew", "SEWForSequenceClassification"), | |||
Comment on lines
-1129
to
+1112
| output = (logits,) + outputs[1:] | ||
| output = (logits,) + outputs[_HIDDEN_STATES_START_POSITION:] |
There was a problem hiding this comment.
This is way simpler to understand! We should do something like that for BERT & friends too
sgugger
approved these changes
Oct 18, 2021
anton-l
approved these changes
Oct 18, 2021
| @@ -1141,8 +1124,8 @@ def forward( | |||
| """, | |||
| HUBERT_START_DOCSTRING, | |||
| ) | |||
| # Copied from transformers.models.wav2vec2.modeling_wav2vec2.Wav2Vec2ForSequenceClassification with Wav2Vec2->Hubert, wav2vec2->hubert, WAV_2_VEC_2->HUBERT | |||
…into refactor_speech_heads
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
* adapt_examples * up * up * up * up * add auto models * finish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adapts all Wav2Vec2-like models to use the same examples and makes sure that
...ForCTCand...ForSequenceClassificationhave exactly the same structure. HuBERT, SEW, SEW-D and soon UniSpeech and others that are based on Wav2Vec2 usually don't have any specific heads, but rather should just follow the Wav2Vec2 head design of CTC and the Superb head design for SequenceClassification (SpeakerVerification, ....). Therefore we should make it as easy as possible to add such heads to new Wav2Vec2 versions.This PR makes sure that a simple
#Copied from ...command can be used for such heads which should allow us to work faster when adding new speech models while making sure the design is unified and correct.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.