-
Notifications
You must be signed in to change notification settings - Fork 25.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Camembert to models exportable with ONNX #14059
Add Camembert to models exportable with ONNX #14059
Conversation
fix `OnnxConfig` import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! It looks very clean.
Could you make sure to run make style
on your branch to get rid of the quality error?
regression/emissions.csv
Outdated
@@ -0,0 +1,8 @@ | |||
timestamp,experiment_id,project_name,duration,emissions,energy_consumed,country_name,country_iso_code,region,on_cloud,cloud_provider,cloud_region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file was added by mistake.
test/emissions.csv
Outdated
@@ -0,0 +1,3 @@ | |||
timestamp,experiment_id,project_name,duration,emissions,energy_consumed,country_name,country_iso_code,region,on_cloud,cloud_provider,cloud_region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know where does these files comes from. It's probably because I tried to run make test
before make style
but it wasn't really needed or successfull :)
I don't understand why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
add suggestion Co-authored-by: Michael Benayoun <mickbenayoun@gmail.com>
…nsformers into add_camembert_config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great, thank!
Add Camembert to models exportable with ONNX Co-authored-by: Thomas.Chaigneau <thomas.chaigneau@arkea.com> Co-authored-by: Michael Benayoun <mickbenayoun@gmail.com>
What does this PR do?
I added lines to make Camembert models available for Onnx conversion.
Issue
This is linked to this conversation #13952
@LysandreJik