Add LayoutXLMProcessor (and LayoutXLMTokenizer, LayoutXLMTokenizerFast) #14115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsRogge
force-pushed
the
add-layoutxlm-fast-tokenizer
branch
from
7d2f83a
to
a0fadfb
Compare
|
have you merged it into master? |
NielsRogge
force-pushed
the
add-layoutxlm-fast-tokenizer
branch
from
ed65739
to
9307a0f
Compare
sgugger
approved these changes
Oct 25, 2021
src/transformers/models/layoutxlm/tokenization_layoutxlm_fast.py
Outdated
Show resolved
Hide resolved
LysandreJik
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
This is fantastic @NielsRogge! Thank you for working on this refactor. Great work adding tests as well.
LGTM!
NielsRogge
force-pushed
the
add-layoutxlm-fast-tokenizer
branch
from
9307a0f
to
b671ea6
Compare
NielsRogge
force-pushed
the
add-layoutxlm-fast-tokenizer
branch
from
7baddaa
to
20dd625
Compare
2 tasks
Albertobegue
pushed a commit
to Albertobegue/transformers
that referenced
this pull request
Jan 27, 2022
…t) (huggingface#14115) * Add LayoutXLMTokenizer and LayoutXLMTokenizerFast * Fix styling issues * Fix more styling issues * Fix more styling issues * Fix docstring * Fix unit tests * Fix docs * Fix unit tests * Fix typos and styling issues * Fix styling issues * Fix docstring * Make all tests of test_tokenization_layoutxlm pass * Add LayoutXLMProcessor * Make fixup * Make all LayoutXLMProcessor tests pass * Minor fixes * Leave LayoutLMv2Processor tests unchanged * Fix code quality * Move LayoutXLM tokenizers and processor to separate folder * Fix code quality * Apply suggestions from code review * Replace assertions by value errors * Remove methods from fast tokenizer Co-authored-by: King Yiu Suen <kingyiusuen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements
LayoutXLMProcessor, which can be used to prepare all data for LayoutXLM. LayoutXLM is a multilingual version of LayoutLMv2. It uses the same vocabulary as XLMRoBERTa.Big thanks to @kingyiusuen for setting up a first draft. This PR is built on his work: #14030
tokenization_layoutxlm.pytokenization_layoutxlm_fast.pyprocessor_layoutxlm.py